Branch: krita-canvasrotation-silvioheinrich

Silvio Heinrich plassy at web.de
Sun Feb 6 18:19:54 CET 2011


On 02/06/2011 10:09 AM, Dmitry Kazakov wrote:
>
>>     Well, if some tests fail, it means that some other subsystem may
>>     fail because of changed guarantees. I think you need to write
>>     what coordinate systems you have now and how your QTransform
>>     objects reflect relations between these coordinate systems.
>     OK i maybe was a bit rash.
>     I reverted all changes and applied the commits again in another
>     arrangement and I changed a few things.
>     Now the tests really do pass, yay :D.
>
>
> That is good. Actually, the tests were my biggest concern. So now you 
> can merge freely =) And the renaming of that QTransform has made the 
> system more clear.
>
> Btw, could you take a look into the bug 
> https://bugs.kde.org/show_bug.cgi?id=265528 ? There is some problem 
> with autoscrolling in KoCanvasControllerWidget. I think it gets 
> non-rotated coordinates. This is not a regression from your patch, so 
> you can do it after the merge, if you want =)
>

Yes I can try to fix it but I think I first need to get a better 
understanding of how all this flake stuff works.

I wanted to make the zooming with the zoom actions (zooming with + & - 
keys) work like zooming
with the mose wheel (relative to the mouse position). But it seems that 
the KoCanvasControllerWidget handles
this internally somehow, so i wonder if I can simply switch this 
behavior on somehow for zooming with actions?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20110206/c1d3d191/attachment-0001.htm 


More information about the kimageshop mailing list