Branch: krita-canvasrotation-silvioheinrich

[Dmitry Kazakov]

>
>  Well, if some tests fail, it means that some other subsystem may fail
> because of changed guarantees. I think you need to write what coordinate
> systems you have now and how your QTransform objects reflect relations
> between these coordinate systems.
>
> OK i maybe was a bit rash.
> I reverted all changes and applied the commits again in another arrangement
> and I changed a few things.
> Now the tests really do pass, yay :D.
>

That is good. Actually, the tests were my biggest concern. So now you can
merge freely =) And the renaming of that QTransform has made the system more
clear.

Btw, could you take a look into the bug
https://bugs.kde.org/show_bug.cgi?id=265528 ? There is some problem with
autoscrolling in KoCanvasControllerWidget. I think it gets non-rotated
coordinates. This is not a regression from your patch, so you can do it
after the merge, if you want =)


-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20110206/bcb6944a/attachment.htm