New mixbrush alpha/beta version
JL VT
pentalis at gmail.com
Wed Mar 31 04:18:30 CEST 2010
A new MixBrush has been prepared!.
It uses KoMixColorsOp to mix colors while respecting color Spaces,
however, due to the <weights> parameter being an integer, it's
absolutely impractical to mix colors in the hundreds.
I attempted to make a workaround with a lengthy recursive function
that performed several small mixing operations, just out of curiosity
as how it would work (and to see the speed). It turned out to take all
my waking day to code it and in the end it didn't solve the issue of
lost precision in the weighting of colors, strange funky mixtures kept
appearing.
Considering I need to write my proposal and work on my thesis (just
like LukasT I've been pushing it to code =P ) I'll wait till we come
out of the feature freeze and CyrilleB can upload a spiffy new Float
option to KoMixColorsOp that allows me to mix thousands of colors with
adequate precision.
With respect to the other concerns, I have some things to say!.
On Mon, Mar 29, 2010 at 8:38 AM, Boudewijn Rempt <boud at valdyas.org> wrote:
> On Monday 29 March 2010, JL VT wrote:
> * comments in English, please
> * please keep to the coding style. I'm not a nit-picker, but indent with 4
> spaces etc. See http://techbase.kde.org/Policies/Kdelibs_Coding_Style
Of course, I warned the code was UGLY, things like dodgy comments and
misaligned indentation are to be expected. But don't worry, normally
I'm very tidy and clear in everything I write, this was a well-warned
exception :]
Did I mention this new version of the brush is thoroughly commented
and tidy?, that's how I normally do everything I do (not just code).
But I don't want to upload it yet as it's essentally broken.
> * same with gui layout :-). It needs to be as similar as possible to the other
> brush engine options.
Oh, in this part I didn't expect much criticism. The title obviously
has to go away (it was a joke), but I found my way to order and
comment each control to be in good taste (they do nothing at the
moment though).
How should it look?.
Well well, time to write the proposal tomorrow. If someone is curious
to see the recursive function or the way the brush behaves at the
moment, I can upload it (but be warned that the recursive function,
despite being tidy, is not commented, and variables take ill-advised
names like "L_nueva", "N_total" and "Val_pix_temp_chico", which I
won't change because the function is useless anyway, haha).
Have a good day!.
More information about the kimageshop
mailing list