KisSliderSpinBox api change

Sven Langkamp sven.langkamp at gmail.com
Tue Mar 16 01:20:37 CET 2010


On Mon, Mar 15, 2010 at 12:07 AM, Cyrille Berger <cberger at cberger.net>wrote:

> On Saturday 13 March 2010, Cyrille Berger wrote:
> > On Saturday 13 March 2010, Sven Langkamp wrote:
> > > On Sat, Mar 13, 2010 at 9:23 AM, Boudewijn Rempt <boud at valdyas.org>
> wrote:
> > > > Does this make it impossible to use the slider for integer values? We
> > > > have a
> > > > number of places where we use integers, like opacity etc.
> > >
> > > Not impossible, you could set decimals to 0 and round the resulting
> > > values. If we don't make the change than you have to be careful to use
> > > the right method.
> > > At the moment e.g. the gradient tool threshold is broken because of
> that.
> >
> > Wouldn't it be possible to have two classes, one for integer and one for
> > float ? (with a base class to share everything)
> Here is a patch with two classes. Could do with even more cleanup, but
> looks
> functional to me.
>
>
Looks good. The only thing I noticed was that the m_slPreviewOpacity is a
KisSliderSpinBox, but uses the qreal signal.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100316/98e894dc/attachment.htm 


More information about the kimageshop mailing list