<div class="gmail_quote">On Mon, Mar 15, 2010 at 12:07 AM, Cyrille Berger <span dir="ltr"><<a href="mailto:cberger@cberger.net">cberger@cberger.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On Saturday 13 March 2010, Cyrille Berger wrote:<br>
> On Saturday 13 March 2010, Sven Langkamp wrote:<br>
> > On Sat, Mar 13, 2010 at 9:23 AM, Boudewijn Rempt <<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>> wrote:<br>
> > > Does this make it impossible to use the slider for integer values? We<br>
> > > have a<br>
> > > number of places where we use integers, like opacity etc.<br>
> ><br>
> > Not impossible, you could set decimals to 0 and round the resulting<br>
> > values. If we don't make the change than you have to be careful to use<br>
> > the right method.<br>
> > At the moment e.g. the gradient tool threshold is broken because of that.<br>
><br>
> Wouldn't it be possible to have two classes, one for integer and one for<br>
> float ? (with a base class to share everything)<br>
</div>Here is a patch with two classes. Could do with even more cleanup, but looks<br>
functional to me.<br>
<br></blockquote><div><br>Looks good. The only thing I noticed was that the m_slPreviewOpacity is a KisSliderSpinBox, but uses the qreal signal. </div></div>