koffice/krita/ui/tests

Dmitry Kazakov dimula73 at gmail.com
Sun Jun 20 12:11:02 CEST 2010


SVN commit 1140323 by dkazakov:

A test for KisDoc2::undoIndexChanged. Fails.

We have a problem with KisDoc2::undoIndexChanged. The problem is it
notifies listeners wrongly! Its 'idx' parameter refers to "the command
that will be executed on the next redo()", but *not* a command that
was undone/redone right now! It means that our mechanism of notifying
listeners is broken. The bug has been reported by Marc, as it affects
transform tool.

I don't know how to fix it as it seems to depend on Qt's QUndoStack
much. So i just wrote the test for the problem. What do you think
about it?

CCMAIL:kimageshop at kde.org


 M  +6 -0      CMakeLists.txt  
 A             kis_doc2_test.cpp   [License: GPL (v2+)]
 A             kis_doc2_test.h   [License: GPL (v2+)]


--- trunk/koffice/krita/ui/tests/CMakeLists.txt #1140322:1140323
@@ -89,3 +89,9 @@
 set(kis_recorded_action_editor_test_SRCS kis_recorded_action_editor_test.cpp )
 kde4_add_unit_test(KisRecordedActionEditorTest TESTNAME krita-ui-KisRecordedActionEditor ${kis_recorded_action_editor_test_SRCS})
 target_link_libraries(KisRecordedActionEditorTest  ${KDE4_KDEUI_LIBS} kritaimage kritaui ${QT_QTTEST_LIBRARY})
+
+########### next target ###############
+
+set(kis_doc2_test_SRCS kis_doc2_test.cpp )
+kde4_add_unit_test(KisDoc2Test TESTNAME krita-ui-KisDoc2Test  ${kis_doc2_test_SRCS})
+target_link_libraries(KisDoc2Test  ${KDE4_KDEUI_LIBS}  komain kritaui kritaimage ${QT_QTTEST_LIBRARY})


More information about the kimageshop mailing list