Rename for KisImage color space conversion interface

Boudewijn Rempt boud at valdyas.org
Wed Jun 9 13:28:27 CEST 2010


On Wed, 9 Jun 2010, Dmitry Kazakov wrote:

> After a short discussion on IRC we concluded that current interface can be
> changed to be easier to understand:
> 
> Here is a proposal of new naming:
> 
> KisImage::convertImageColorSpace(const KoColorSpace *dstColorSpace,
> KoColorConversionTransformation::Intent renderingIntent)
> converts color space of all the nodes of the image and image's projection

Ok

> 
> KisImage::assingImageProfile(const KoColorProfile *profile)
> assigns a new profile to every node.
> ^^ this is very disputable, because the user can get unexpected results if
> his stack contains a mix of different color spaces. Should we leave it?

Let's not have this

> 
> KisImage::convertRootLayerColorSpace(const KoColorSpace *dstColorSpace,
> KoColorConversionTransformation::Intent renderingIntent)
> or
> KisImage::convertProjectionColorSpace(const KoColorSpace *dstColorSpace,
> KoColorConversionTransformation::Intent renderingIntent)
> converts rootLayer->projection() only. All the other layers are untouched.

Projection is better, I think

> 
> KisImage::assingProjectionProfile(const KoColorProfile *profile)
> assigns a new profile to rootLayer->projection() only. All the other layers
> are untouched.
> 

Ok

> 
> 
> -- 
> Dmitry Kazakov
> 



More information about the kimageshop mailing list