koffice/krita/image/filter

[Ed .]

Not really. But what if there is a case where you do not want the selection to affect the compositing operation?

> Date: Tue, 5 Jan 2010 10:48:17 +0100
> From: boud at valdyas.org
> To: kimageshop at kde.org
> Subject: Re: koffice/krita/image/filter
> CC: kde-commits at kde.org
> 
> On Tue, 5 Jan 2010, Dmitry Kazakov wrote:
> 
> > On Tue, Jan 5, 2010 at 1:01 AM, Edward Apap <schumifer at hotmail.com> wrote:
> > 
> > > SVN commit 1070110 by eapap:
> > >
> > > Use COMPOSITE_COPY when applying filter result
> > >
> > >
> > >  M  +1 -1      kis_filter_job.cpp
> > >
> > >
> > > --- trunk/koffice/krita/image/filter/kis_filter_job.cpp #1070109:1070110
> > > @@ -64,7 +64,7 @@
> > >
> > >     // blt back onto the original
> > >     KisPainter p2(m_dev);
> > > -    p2.setCompositeOp(m_dev->colorSpace()->compositeOp(COMPOSITE_OVER));
> > > +    p2.setCompositeOp(m_dev->colorSpace()->compositeOp(COMPOSITE_COPY));
> > >     p2.setSelection(m_selection);
> > >     p2.bitBlt(m_rc.topLeft(), dst, m_rc);
> > >     p2.end();
> > >
> > 
> > COMPOSITE_COPY doesn't pay any attention to the selections. At least it used
> > to. Please check whether this patch breaks selected filter application.
> 
> Was there any reason for not fixing composite copy to take the mask into account?
> 
> Boudewijn
> 
> _______________________________________________
> kimageshop mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
 		 	   		  
_________________________________________________________________
Windows Live: Friends get your Flickr, Yelp, and Digg updates when they e-mail you.
http://www.microsoft.com/middleeast/windows/windowslive/see-it-in-action/social-network-basics.aspx?ocid=PID23461::T:WLMTAGL:ON:WL:en-xm:SI_SB_3:092010
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100105/98369b48/attachment.htm