<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
--></style>
</head>
<body class='hmmessage'>
Not really. But what if there is a case where you do not want the selection to affect the compositing operation?<br><br>> Date: Tue, 5 Jan 2010 10:48:17 +0100<br>> From: boud@valdyas.org<br>> To: kimageshop@kde.org<br>> Subject: Re: koffice/krita/image/filter<br>> CC: kde-commits@kde.org<br>> <br>> On Tue, 5 Jan 2010, Dmitry Kazakov wrote:<br>> <br>> > On Tue, Jan 5, 2010 at 1:01 AM, Edward Apap <schumifer@hotmail.com> wrote:<br>> > <br>> > > SVN commit 1070110 by eapap:<br>> > ><br>> > > Use COMPOSITE_COPY when applying filter result<br>> > ><br>> > ><br>> > > M +1 -1 kis_filter_job.cpp<br>> > ><br>> > ><br>> > > --- trunk/koffice/krita/image/filter/kis_filter_job.cpp #1070109:1070110<br>> > > @@ -64,7 +64,7 @@<br>> > ><br>> > > // blt back onto the original<br>> > > KisPainter p2(m_dev);<br>> > > - p2.setCompositeOp(m_dev->colorSpace()->compositeOp(COMPOSITE_OVER));<br>> > > + p2.setCompositeOp(m_dev->colorSpace()->compositeOp(COMPOSITE_COPY));<br>> > > p2.setSelection(m_selection);<br>> > > p2.bitBlt(m_rc.topLeft(), dst, m_rc);<br>> > > p2.end();<br>> > ><br>> > <br>> > COMPOSITE_COPY doesn't pay any attention to the selections. At least it used<br>> > to. Please check whether this patch breaks selected filter application.<br>> <br>> Was there any reason for not fixing composite copy to take the mask into account?<br>> <br>> Boudewijn<br>> <br>> _______________________________________________<br>> kimageshop mailing list<br>> kimageshop@kde.org<br>> https://mail.kde.org/mailman/listinfo/kimageshop<br> <br /><hr />Windows Live: <a href='http://www.microsoft.com/middleeast/windows/windowslive/see-it-in-action/social-network-basics.aspx?ocid=PID23461::T:WLMTAGL:ON:WL:en-xm:SI_SB_3:092010' target='_new'>Friends get your Flickr, Yelp, and Digg updates when they e-mail you.</a></body>
</html>