A first part of the layers/masks patch

[Dmitry Kazakov]

On Sat, Sep 26, 2009 at 10:44 AM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Wednesday 23 September 2009, Dmitry Kazakov wrote:
>
> > This is a singlepatch version. It can be easily applied to trunk without
> > conflicts. It's good for testing, not for reading:
> > http://dimula73.narod.ru/01_layers_masks_refactoring_singlepatch.diff
>

Yes, recent commits broke it. I'm compiling newly merged one.



> There are a couple of stylistic issues I'm not too happy with, like
> rearranging the order of methods in a header and some renaming.

I just wanted to make them more readable by grouping resembling methods.



> Right now, for
> someone who's been working with Krita for a longer time, confusion is
> guaranteed between the term 'projection; and the new term 'cache'.
>

Btw, there is no new term 'cache' =) Do you mean
KisGroupLayer::resetCache()?
I changed it from resetProjection to resetCache because KisAdjustmentLayer
had already had similar method. They both should have the same name. And
their name can't be resetProjection because now they reset 'original' paint
device instead of 'projection'

I'll write about projections, originals and painDevices in a reply to your
next mail.


>
> These big refactors go better if we keep the renaming to the end, I think.
> I'm
> still digesting your other mail, it's as long as the patch!
>

=)


-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20090926/34007286/attachment.htm