A first part of the layers/masks patch

[Dmitry Kazakov]

On Sat, Sep 26, 2009 at 10:17 AM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Saturday 26 September 2009, Dmitry Kazakov wrote:
> > > Yes, all selection tools will not work on the mask but on the
> selection.
> > > So even if you have selected the mask all changes with selection tools
> > > will go to the global selection.
> >
> > Exactly!
> >
> > > We might want to kill the actions in the mask menu. See the other
> thread.
> >
> > We should kill them in layerBox and share them with mask manager.
> >
>
> Actually, the actions aren't implemented in the layerbox, but in the node
> model. The layerbox only refers the the node manager (at least, it was that
> way when I implemented it, I should check again.) But generally speaking, I
> prefer the gui to be in the layerbox.
>

What we have now:

KisMaskManager - has it's own KActions for all the mask operations
KisLayerManager - has it's own KActions for all the layer operations
KisLayerBox - has it's own KActions for all the layer ans mask operations
(and some of them are created twice even)
This means that "Filter Layer..." menu-item has three(!) clones.

You don't think it's normal, do you?


As i remember KAction is created exactly to ensure that an action is created
ONCE only. We just break this idea.

How it should be, i think:
KisMaskManager - has it's own KActions for all the mask operations
KisLayerManager - has it's own KActions for all the layer operations
KisLayerBox - just gets pointers for actions from KisMaskManager and
KisLayerManager. It must not create any KAction related to masks or layers.


PS:

By the way, we are getting  "dividends" from this actions-duplication
already. Filter masks have different names in menubar and in layerbox's
context-menu.
"Filter Mask..." against "Effect Mask...".

And don't even try to simply change a string in KisMaskManager - this will
be just another "dirty hack" that will help us to make our codebase
completely unmaintainable. =(

-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20090926/b9a937f5/attachment.htm