<br><br><div class="gmail_quote">On Sat, Sep 26, 2009 at 10:17 AM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Saturday 26 September 2009, Dmitry Kazakov wrote:<br>
</div><div><div></div><div class="h5">> > Yes, all selection tools will not work on the mask but on the selection.<br>
> > So even if you have selected the mask all changes with selection tools<br>
> > will go to the global selection.<br>
><br>
> Exactly!<br>
><br>
> > We might want to kill the actions in the mask menu. See the other thread.<br>
><br>
> We should kill them in layerBox and share them with mask manager.<br>
><br>
<br>
</div></div>Actually, the actions aren't implemented in the layerbox, but in the node<br>
model. The layerbox only refers the the node manager (at least, it was that<br>
way when I implemented it, I should check again.) But generally speaking, I<br>
prefer the gui to be in the layerbox.<br>
</blockquote></div><br>What we have now:<br><br>KisMaskManager - has it's own KActions for all the mask operations<br>KisLayerManager - has it's own KActions for all the layer operations<br>KisLayerBox - has it's own KActions for all the layer ans mask operations (and some of them are created twice even)<br>
This means that "Filter Layer..." menu-item has three(!) clones.<br><br>You don't think it's normal, do you?<br><br><br>As i remember KAction is created exactly to ensure that an action is created ONCE only. We just break this idea.<br>
<br>How it should be, i think:<br>KisMaskManager - has it's own KActions for all the mask operations<br>
KisLayerManager - has it's own KActions for all the layer operations<br>
KisLayerBox - just gets pointers for actions from KisMaskManager and KisLayerManager. It must not create any KAction related to masks or layers.<br><br><br>PS:<br><br>By the way, we are getting "dividends" from this actions-duplication already. Filter masks have different names in menubar and in layerbox's context-menu.<br>
"Filter Mask..." against "Effect Mask...".<br><br>And don't even try to simply change a string in KisMaskManager - this will be just another "dirty hack" that will help us to make our codebase completely unmaintainable. =(<br clear="all">
<br>-- <br>Dmitry Kazakov<br>