Review request: Masks support compositeOps and opacity

Dmitry Kazakov dimula73 at gmail.com
Fri Oct 23 17:23:40 CEST 2009


Hi, all!

Sorry for not using reviewboard, it doesn't accept git patches and svn
creates quite messy patches when a file is moved to a different location =)

Well, here is a patch that allows masks to use different compositeOps and
opacity. Now a user can choose how a mask will be applied to the layer. It
makes sense in some circumstances. You can test it with a test file in
attachment.

Tetscase:
1) If you set mask's composition to "normal", then a selection will be
darker than a background.
2) If you set it to "Alpha darken", then it will dissolve in a background.

To achieve this i moved colorspace, composition and opacity stuff from
KisLayer to KisBaseNode, therefore masks can use it too.

Have i forgotten to move something connected to colorspaces alongside?

Waiting for your critique! =)


-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20091023/93fa6c94/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 00_masks_composite_ops.diff
Type: text/x-patch
Size: 45062 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20091023/93fa6c94/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_transparency_blur.kra
Type: application/x-krita
Size: 97135 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20091023/93fa6c94/attachment-0001.kra 


More information about the kimageshop mailing list