New feature for review

[Elián Hanisch]

> Basically I want to be able to change the size of the brush quickly. So I
> implemented the wishlist [2] a bit and now we have two possibilities. The
>  old patch is not applicable at the trunk anymore :/ I hoped you to review
>  little faster ;( .

> Here is the new patch [1] and now when you press Shift and drag with mouse
> left/right the spray brush changes it's size. Change the cursor mode to
>  _brush outline_ to see changes.
> 
> If you would move up/down, different behaviour can be coded, like the wish
>  list is saying e.g. setting the softness in default paintop. Better brush
>  outline preview should be available but that is long-time aim.
I like it a lot, I already want this for all paintops  :D
I suggest using a visual aid like an horizontal line across the canvas and 
centred in the middle of the cursor so is clear that you're modifying 
something.

I'm not sure if vertical movement  should resize as well, I think moving the 
cursor left/right is good enough, and it's probably easier than moving the 
hand vertically (if you want to draw a straight line, which is easier?, 
horizontal or vertical?)

as for changing the  softness with vertical movement, I like the idea so I did 
like to see it, but as enkithan said it may prove to be difficult to move just 
in one direction. Anyway a better feedback than the one suggested in the bug 
report (the 0-100 number) would be a second circle inside the cursor

For what I can see, shift+click conflicts with the duplicate paintop, maybe 
change the duplicate paintop so it uses ctrl or something else?

> The patch has bug -- it moves with the mouse position. You probably want to
> change the size and not move with the mouse on the canvas.
yes, cursor should not move.

> Please review! I want to commit and develop in trunk if possible.

> [1]
>  http://lukast.mediablog.sk/patches/wishlist-change-brush-size-with-shift-
>  left-click.patch
> [2] https://bugs.kde.org/show_bug.cgi?id=145777
> _______________________________________________
> kimageshop mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
> 

-- 
~ m4v