Patch for KCurve and KisPerChannelFilter

Дима Казаков dimula73 at gmail.com
Thu Feb 19 21:16:16 CET 2009


Good evening everyone!

I'm very interested in Krita and would like to join your project.

The first thing I disliked in Krita was Color Adjustment Curves Filter. It
worked quite badly, so i decided to improve it. And here is the patch:

What is done:
KCurve:
- implemented cubic splines in KCurve widget. Now all the calculations are
made inside KCubicSpline template.
- faster calculations of the spline because of caching of the coefficients
inside the template
- faster (*much faster*) redrawing of the curve because of caching of the
_scaled_ @m_pix histogram image in @m_pixmapCache object
- fixed 'out_of_range' bug when you tried to delete the last point of the
curve

KCurve+KisPerChannelWidget
- added In/Out spinboxes like in photoshop to allow user to modify the curve
with keyboard
- with spinboxes you can move the point to any place of the curve, so you
can change the order of the points
- added handy function that creates new point in the middle of the curve and
focuses on spinboxes to set it
- and a few small fixes


The fist patch changes KCurve class. The second one makes
KisPerChannelFilter use new features.

PS:
What is planned to be done:
1) Look through preview mechanism, because it still slows everything down
much.
2) Let user unselect the point of the curve by clicking on empty area
2,5) Hide In/Out controls when nothing selected
3) Far-far-future: color sampler mode for the curve (clicking on the canvas
shows the point on the curve)


-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20090219/6a3ea312/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kcurve_cubic_splines.patch
Type: application/octet-stream
Size: 29896 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20090219/6a3ea312/attachment-0002.dll 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kis_perchannel_filter_new_kcurve.patch
Type: application/octet-stream
Size: 20246 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20090219/6a3ea312/attachment-0003.dll 


More information about the kimageshop mailing list