are selections part of kispaintdevice or aren't they?

[Boudewijn Rempt]

On Thursday 04 October 2007, Cyrille Berger wrote:
> On Thursday 04 October 2007, Boudewijn Rempt wrote:
> > My feeling is that the only solution is to take KisSelection away from
> > KisPaintDevice, but that means that the iterator's isSelected methods no
> > longer work and that we have to manually create an iterator on a
> > selection every time we access a paint device.
> >
> > Any ideas?
>
> Wondering about that. A possibility is to give the KisSelection as a
> createIterator/createRandomAccessor parameter. The question is wether it's
> only laziness on our part (less code change, but no shame to that :) ) or
> does it also make sense API wise (and do we care enought ?) ?

I've been sleeping on this. Passing a selection as a parameter to the iterator 
sounded like a good thing at first, but then I thought, it would only 
complicate the code. We'd still need ot pass the selection to the filters and 
everywhere else. I'm not sure whether the convenience of isSelected() and 
selectedness() compensates for that.

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20071006/8ed3fc5a/attachment.pgp