Fwd: [Bug 135165] Rotating an imported NEF (Nikon RAW) image 180° produces empty area, undoing produces empty image

Boudewijn Rempt boud at valdyas.org
Thu Oct 5 22:02:44 CEST 2006


Just a question related to the solution to this bug -- perhaps someone on the 
list knows the answer...

* Why do we have to open the source iterator writable?
-        KisHLineIteratorPixel srcIt = src->createHLineIterator(r.x(), y, 
r.width(), false);
+        KisHLineIteratorPixel srcIt = src->createHLineIterator(r.x(), y, 
r.width(), true);

* Why do we try to set the alpha channel of the source paint device?

data = srcIt.rawData();
// XXX: Should set alpha = alpha*(1-selectedness)
cs->setAlpha(data, 0, 1);

Cyrille, Bart and me, we're all baffled as bathroom geysers, although pretty 
elated that this bug has been solved in time for 1.6.
-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi
-------------- next part --------------
An embedded message was scrubbed...
From: unknown sender
Subject: no subject
Date: no date
Size: 3287
Url: http://mail.kde.org/pipermail/kimageshop/attachments/20061005/0f1accff/attachment.mht 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20061005/0f1accff/attachment.pgp 


More information about the kimageshop mailing list