Iterator

[Boudewijn Rempt]

On Saturday 28 January 2006 19:41, Cyrille Berger wrote:
> > Sounds like a very workable idea. As far as I'm concerned you can add it
> > and document it.
> > However, be careful not to change existing code that uses
> > the iterators
>
> I will keep touching KisPainterConvolution, as it is unfinished and still
> damn too slow (for a 2900x1900 image, gimp takes less than 2 seconds to
> blur it, we were at 30s, and now down to 15s which is still too much)

That would be okay, of course. I mean -- if you add a move-to-next-scanline
method to the hline iterator, don't update all code to use that instead of
an ordinary loop. That would break too much. But if it helps with fixing the
convolution painter, that's fine.

Just one thing: make sure the convolution painter code remains understandable. 
Our first version was extremely cryptic, and that made sure it was also very 
buggy.

>
> > nor the meaning of existing code inside the iterator. I'm
> > sure it will give regressions if we do that.
>
> I won't touch existing code inside iterators just adding some :)

Great!

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20060128/120fae2d/attachment.pgp