SIOX

[Boudewijn Rempt]

On Sunday 05 February 2006 14:26, Michael Thaler wrote:
> On Sunday 05 February 2006 14:16, Boudewijn Rempt wrote:
> > I think these would be safe to add. They should be independent of
> > anything else in the selection or selection manager code.
>
> Actually that were just the names in the siox.c code. For example, there is
> already a grow() function in KisSelectionManager.
>
> The action is commented out right now
>
> #if 0
> m_grow =
>         new KAction(i18n("Grow"),
>                 0, 0,
>                 this, SLOT(grow()),
>                 collection, "grow");
> #endif
>
> Then:
>
> void KisSelectionManager::grow() {}
>
> Shouldn't it be save to just implement the function because it is not used
> anywhere, anyway?
>
> (One of course has to grep the source-code to make sure it is actually not
> used anywhere, but if this really is the case, I think it would make more
> sense not to introduce new dublicate the functions that are already there.
>

You can implement the code, but not comment in the action because that would 
give new strings for the translators, or so I think.

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20060205/c6b68cda/attachment.pgp