koffice/krita/core

[Patrick Julien]

On March 6, 2004 01:20 pm, Adrian Page wrote:
> On Saturday 06 March 2004 1:49 pm, Boudewijn Rempt wrote:
> > Well, I showed the options to my in-house quality team, and they
> > unanimously voted for blue bell peppers and purple sunbursts as opposed
> > to the coloured ones. I'm not sure what the correct terminology would be,
> > but 'use colour as mask' could describe it. I never really thought about
> > supporting coloured brushes, since I thought that that could be handled
> > better by the stamp tool. Not that it's not nice to have; but I like to
> > have both :-)
>
> Ok, I'll add an option to switch between the two.
>
> The 'blue bell peppers' and 'purple sunbursts' are actually the result of
> some undefined behaviour on the part of the compiler. In:
>
> qRgba(255 - m_data[k++], 255 - m_data[k++], 255 - m_data[k++],
>   255 - m_data[k++])
>

Here, using MAX_OPACITY and downscale are required to retain the code's 
compile time independence on the channel depth.