koffice/krita/tools

[Boudewijn Rempt]

On Wednesday 25 August 2004 12:58, you wrote:
> CVS commit by coppens:
>
> Fill selections. Quite slow, though, since we have to check the whole layer
> instead of the relatively small selected area.
>

I've been thinking about that. Perhaps I could make KisPainter::dirtyRect into 
a signal that could slot into the selections, so whenever something is 
painted on a selection, the selection knows which area is dirty. Adding up 
all the dirty rects into a new rect that represents the area the selection 
covers and add a getSelectionExtent to KisSelection would then make gradients 
and fills and so on a lot easier.

In other news, since KisPainter is getting a bit too big to handle 
comfortably, I've starting splitting it. Would it be possible for you to move 
the fill code to a KisFillPainter analogous to KisGradientPainter (together 
with the fill code from KisPainter itself, perhaps)? 

(I'm already moving all the paint operations to separate PaintOp classes -- if 
you've got an enum that's a selector for behaviour, you basically have got a 
class, I feel.)

-- 
Boudewijn Rempt | http://www.valdyas.org/fading/index.cgi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20040825/66ba6f18/attachment.pgp