Acid2 fixes

[Dave Hyatt]

I have saved the patches and was planning on posting them to this  
list once they've been shaken out a bit.  If you're really eager to  
get them early I could post them, but e.g., one of them has caused a  
bad regression on news.com.

dave

On Apr 26, 2005, at 12:32 AM, Allan Sandfeld Jensen wrote:

> Hello Apple people
>
> I saw Dave was working on Acid2, so rather than duplicate the  
> effort I wonder
> if you would care to post the patches here before Safari 1.3.1?
>
> Especially some of the first things (min max on positioned  
> elements) are nice,
> but I don't think we really want SGML comment parsing in KHTML.
>
> To make a little trade: Here is a cookie for you ;)  (you don't  
> seem to be
> reading khtml-cvs much).
> You might have noticed Google Suggest don't work fully in Safari  
> anymore. You
> need to implement window.frameElement like my patch below does. I  
> think it is
> also what fixed address-completion in GMail.
>
> `Allan
> Index: kjs_window.cpp
> ===================================================================
> RCS file: /home/kde/kdelibs/khtml/ecma/kjs_window.cpp,v
> retrieving revision 1.398
> retrieving revision 1.401
> diff -u -3 -p -r1.398 -r1.401
> --- kjs_window.cpp    12 Mar 2005 01:15:49 -0000    1.398
> +++ kjs_window.cpp    4 Apr 2005 10:39:42 -0000    1.401
> @@ -224,6 +224,7 @@ const ClassInfo Window::info = { "Window
>    status    Window::Status        DontDelete
>    document    Window::Document    DontDelete|ReadOnly
>    Node        Window::Node        DontDelete
> +  frameElement        Window::FrameElement        DontDelete|ReadOnly
>    Event        Window::EventCtor    DontDelete
>    Range        Window::Range        DontDelete
>    NodeFilter    Window::NodeFilter    DontDelete
> @@ -571,6 +572,8 @@ Value Window::get(ExecState *exec, const
>          part->end();
>        }
>        return getDOMNode(exec,part->document());
> +    case FrameElement:
> +      return retrieve(m_frame->m_part);
>      case Node:
>        return getNodeConstructor(exec);
>      case Range:
> Index: kjs_window.h
> ===================================================================
> RCS file: /home/kde/kdelibs/khtml/ecma/kjs_window.h,v
> retrieving revision 1.110
> retrieving revision 1.111
> diff -u -3 -p -r1.110 -r1.111
> --- kjs_window.h    12 Mar 2005 01:15:49 -0000    1.110
> +++ kjs_window.h    3 Apr 2005 16:24:14 -0000    1.111
> @@ -130,7 +130,7 @@ namespace KJS {
>             InnerWidth, Length, _Location, Navigate, Name,  
> _Navigator, _Konqueror, ClientInformation,
>             OffscreenBuffering, Opener, OuterHeight, OuterWidth,  
> PageXOffset, PageYOffset,
>             Parent, Personalbar, ScreenX, ScreenY, Scrollbars,  
> Scroll, ScrollBy,
> -           ScreenTop, ScreenLeft, AToB, BToA,
> +           ScreenTop, ScreenLeft, AToB, BToA, FrameElement,
>             ScrollTo, ScrollX, ScrollY, MoveBy, MoveTo, ResizeBy,  
> ResizeTo, Self, _Window, Top, _Screen,
>             Image, Option, Alert, Confirm, Prompt, Open,  
> SetTimeout, ClearTimeout, XMLHttpRequest, XMLSerializer,
>             Focus, Blur, Close, SetInterval, ClearInterval,  
> CaptureEvents, ReleaseEvents,
> _______________________________________________
> Khtml-devel at kde.org
> https://mail.kde.org/mailman/listinfo/khtml-devel