Scope in event handlers

Maciej Stachowiak mjs at apple.com
Tue Apr 19 00:29:07 CEST 2005


On Apr 18, 2005, at 4:59 AM, David Faure wrote:

> A related topic: kjs_proxy.cpp has now become a useless  
> intermediate layer.
> It used to be necessary when dlopening the code in the ecma subdir  
> (kjs_html.so iirc)
> from libkhtml, but we don't do that anymore (it broke with rtti and  
> DOM exceptions).
> So this intermediate layer can certainly be cleaned up now, at  
> least the interface/impl
> thing, or even moving all that code to e.g. kjs_binding.h's  
> ScriptInterpreter and
> getting rid of the "proxy" intermediate. What do you think?

I completely agree. I suggest just putting the code in  
ScriptInterpreter.

> If we perform that cleanup here, would you apply the patch to  
> Safari too? (If not, I don't
> want to do something that will make it harder to merge patches  
> later on).
> Or vice versa, do you feel like cleaning it up? :-)

If you did the cleanup I would apply the patch to our code-base. It's  
on my list of things to clean up someday, but I am not sure how soon  
I would be able to get around to it.

Regards,
Maciej




More information about the Khtml-devel mailing list