fast/parser/font.html

Dirk Mueller mueller at kde.org
Tue Feb 10 23:58:26 CET 2004


On Tuesday 10 February 2004 23:33, David Hyatt wrote:

> Here's the patch that went with that checkin:

Yeah, I saw that. I don't see any case where the change would make a 
difference though, thats why I'm curious :)

> The problem is that font is applied first (it has a higher priority),
> and then line-height is applied.

Correct, and I think the fix would be to apply line-height as "first" as well, 
similiar to font. Those two are very closely related via the font shorthand 
anyway. see patch. 

> The bug I was fixing (if I remember correctly) was that line-height
> specified inside the font property was actually being completely
> ignored for one of the cases in fast/parser/fonts.html.

Hmm. I don't see how that can happen..

> all of those tests in fonts.html then maybe you made a different fix or
> already have the fix in question.

I'm not sure if I pass the tests since I don't have access to Safari to 
compare with. what I see is http://khtml.homeip.net/font.png 


Dirk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cssstyleselector.diff
Type: text/x-diff
Size: 1259 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/khtml-devel/attachments/20040210/ff7eddb8/cssstyleselector.bin


More information about the Khtml-devel mailing list