fast/parser/font.html

[David Hyatt]

Here's the patch that went with that checkin:

Index: cssparser.cpp
===================================================================
RCS file: /local/home/cvs/Labyrinth/WebCore/khtml/css/cssparser.cpp,v
retrieving revision 1.50
retrieving revision 1.49
diff -r1.50 -r1.49
6c6
<  * $Id: cssparser.cpp,v 1.50 2003/11/03 22:43:22 hyatt Exp $
---
 >  * $Id: cssparser.cpp,v 1.49 2003/11/03 18:22:29 hyatt Exp $
1516,1518c1516
<     }
<
<     if (!font->lineHeight)
---
 >     } else {
1519a1518
 >     }

The test case you sent doesn't work in Safari for a different reason.  
The problem is that font is applied first (it has a higher priority), 
and then line-height is applied.

The bug I was fixing (if I remember correctly) was that line-height 
specified inside the font property was actually being completely 
ignored for one of the cases in fast/parser/fonts.html.  If you pass 
all of those tests in fonts.html then maybe you made a different fix or 
already have the fix in question.

Cheers,
dave

On Feb 10, 2004, at 2:22 PM, Dirk Mueller wrote:

> On Tuesday 10 February 2004 23:07, David Hyatt wrote:
>
>> This is an evil Hixie test (from Ian Hickson).  It's making sure that
>> all of the font properties are correctly parsed.  Assuming you have 
>> the
>> Ahem font properly installed, then if each shorthand is correctly
>> parsed, you end up with the white Ahem glyphs (which are just squares)
>> obscuring the red backgrounds of the spans.
>
> Ah, I see. Ok, then I have another question: I was looking at
>
> 2003-11-03  David Hyatt  <hyatt at apple.com>
>
>         Fix for 3472030, line-height not properly reset in all cases 
> when the
>         font shorthand is used.
>
>         Reviewed by mjs
>
>         * khtml/css/cssparser.cpp:
>         (CSSParser::parseFont):
>
>
> and merging the diff, it doesn't fix anything. can you confirm that the
> attached testcase works with Safari?
>
> But I see neither effect in both testcases.. so what is the testcase 
> for this
> changelog entry?
>
> (there is no way for externals to resove these rdar entries in the 
> changelog
> is there?)
>
> <lineheight.html>_______________________________________________
> Khtml-devel at kde.org
> https://mail.kde.org/mailman/listinfo/khtml-devel