kdelibs/khtml

[Alexander Kellett]

hiya,

On Tue, Jan 14, 2003 at 12:01:13PM +0200, Antti Koivisto wrote:
> Thanks for going through these!

no problem, they were just
the changes left in my kdelibs/khtml
after i cvs up'ed :)

> > html/html_baseimpl.cpp:
> >    1) HTMLFrameElementImpl::attach():
> 
> didn't want to mess with frame changes yet.

ok, i'm guessing they are only very seldomly possible
if not theoretical crash cases in any case :)

> > html/html_objectimpl.cpp:
> >    not certain, but looks like this would be needed to make sure something
> >    doesn't occur before the renderer is intantiated
> 
> hmm?

well, it was "(attached)" and is now "(attached && m_render)"
and with the fouc changes isn't it possible for 
(attached) != (attached && m_render) ?

not to sure though. i really didn't read enough of the khtml
code to fully understand the addChild and attach mechanisms.

> >    rendering/render_container.cpp:
> >       without this _very_ ugly fix www.nvidia.com assert's on me
> >       maybe the removal of blockBidi fixes this? i've no idea ;-)
> 
> The real fix was to prevent creation of RenderHtml:s with display:none.

aaah. it would have taken me months to find that fix :)

nice to see you back into devel btw!

mvg,
Alex

-- 
"[...] Konqueror open source project. Weighing in at less than
            one tenth the size of another open source renderer"
Apple,  Jan 2003 (http://www.apple.com/safari/)