kdelibs/khtml

[Antti Koivisto]

Hi,

Thanks for going through these!

> css/cssstyleselector.cpp:
>    make sure to cleanup styleNotYetAvailable in CSSStyleSelector::clear()

yeah.

> html/html_baseimpl.cpp:
>    1) HTMLFrameElementImpl::attach():

didn't want to mess with frame changes yet.

> html/html_formimpl.cpp:
>    fix needed for closeRenderer?
> html/html_objectimpl.cpp:
>    not certain, but looks like this would be needed to make sure something
>    doesn't occur before the renderer is intantiated

hmm?

> html/htmlparser.cpp:
>    use closeRenderer

good catch.

> rendering/render_style.cpp / rendering/render_style.h:
>    add RenderStyle::isStyleAvailable

it was used only in frame code, which i didn't change yet.

> xml/xml_tokenizer.cpp:
>    use closeRenderer

another good catch.

>    rendering/render_container.cpp:
>       without this _very_ ugly fix www.nvidia.com assert's on me
>       maybe the removal of blockBidi fixes this? i've no idea ;-)

The real fix was to prevent creation of RenderHtml:s with display:none.


  antti


> patch attached for the above stuff. though i've hand edited it
> a bit, so i may not apply cleanly. also its entirely untested as
> kdelibs doesn't want to build for me :(
>
> also, you added m_media, m_type and "disabled" support but
> i wasn't sure that this was really needed for fouc. alternative
> on the other hand seemed to be needed as otherwise all alternative
> css's would delay rendering. well, i guess that would be the case
> anyways.
>
> mvg,
> Alex
>
> On Tue, Jan 14, 2003 at 03:14:38AM +0100, Antti Koivisto wrote:
> > CVS commit by koivisto:
> >
> > Flash of unstyled content (FOUC) fixes ported from Safari.
> >
> > - note the changes in html_baseimpl.cpp to prevent creation
> > of RenderHtml with display:none.
> > - virtual isInline() is evil
> >
> > CCMAIL: khtml-devel@kde.org
> >
> >
> >   M +11 -0     css/cssstyleselector.cpp   1.248
> >   M +3 -1      css/cssstyleselector.h   1.32
> >   M +12 -6     html/html_baseimpl.cpp   1.176
> >   M +44 -1     html/html_elementimpl.cpp   1.153
> >   M +3 -1      html/html_elementimpl.h   1.63
> >   M +76 -19    html/html_headimpl.cpp   1.96
> >   M +14 -4     html/html_headimpl.h   1.39
> >   M +2 -1      rendering/render_flow.h   1.75
> >   M +33 -4     xml/dom_docimpl.cpp   1.212
> >   M +25 -2     xml/dom_docimpl.h   1.104
> >   M +44 -7     xml/dom_nodeimpl.cpp   1.201
> >   M +7 -3      xml/dom_nodeimpl.h   1.141
> >   M +2 -2      xml/xml_tokenizer.cpp   1.41
> >
> >
> >
> > _______________________________________________
> > Khtml-devel@mail.kde.org
> > http://mail.kde.org/mailman/listinfo/khtml-devel