anybody mind if I commit my changes?

[Dirk Mueller]

On Fre, 08 Aug 2003, David Hyatt wrote:

> You're basically seeing two independent Safari patches at work here.  
> TextSlaves were renamed to TextRuns before the full inline box model 
> landed.  I like the name InlineTextBox as well.

Great :)

> >d) Why is it named InlineBox anyway? CSS specs talk about Line boxes, 
> >not
> >   Inline Boxes..
> Section 9.2.2.  The term "inline box" is used repeatedly to refer to 
> the boxes for inline elements like <em>s, and also to refer to 
> "anonymous inline boxes" created for text runs.

Ok, but thats not really what it does here, right?

Read Section 9.4.2. 

"Since an inline box may not exceed the width of a line box, long inline 
boxes are split into several boxes and these boxes distributed across 
several line boxes. When an inline box is split, margins, borders, and
padding have no visual effect where the split occurs (or at any split, when 
there are several). Formatting of margins, borders, and padding may not be 
fully defined if the split occurs within a bidirectional
embedding. 

Inline boxes may also be split into several boxes within the same line box 
due to bidirectional text processing. "

If I understand the purpose of the patches correctly (which I didn't much 
look into yet I must admit), then the correct term is "line box", which is a 
visual representation of a "line of text" in the easiest case, but it can be 
more complex (containing other inline elements, like images etc).  

> The spec basically uses both, so I don't feel strongly either way.  Do 
> you like LineBox better?

I believe the spec makes a strong distinction between "inline boxes" and 
"line boxes", both referring to two different things. Therefore, LineBox 
is more correct in my opinion. 

So we rename TextSlave aka TextRun aka TextLineBox, agree? or LineTextBox?

> The function does actually use end, but not start.  I had it on my list 
> of things to clean up to remove the start argument.  The function only 
> iterates over the runs constructed for a given line.

Ok, thanks for explanation. As long as it doesn't drop off the "cleanup" 
list, I'm fine with it. 


-- 
Dirk