anybody mind if I commit my changes?

[Leo Savernik]

Oops, while I was composing my answer, I didn't realize you posted here.

Am Freitag, 8. August 2003 22:47 schrieb David Hyatt:
> On Friday, August 8, 2003, at 12:34PM, Dirk Mueller wrote:
> > c) TextSlave -> TextRun rename. While I again miss the point of
> > renaming
> >    it to something that is remarkable similiar to BidiRun (which is
> > however
> >    a different thing), I'm wondering why it has to inherit InlineBox
> > (which
> >    is quite a huge class). There are tons of TextSlaves created, and
> > this
> >    is a nontrivial overhead IMHO. Also, for consistency I would suggest
> >    a name line InlineTextBox instead (similiar to InlineFlowBox).
>
> You're basically seeing two independent Safari patches at work here.
> TextSlaves were renamed to TextRuns before the full inline box model
> landed.  I like the name InlineTextBox as well.

So should I rename it to InlineTextBox, and you'll change it in WebCore, too?
>
> > d) Why is it named InlineBox anyway? CSS specs talk about Line boxes,
> > not
> >    Inline Boxes..
[...]
> The spec basically uses both, so I don't feel strongly either way.  Do
> you like LineBox better?

Rename what to LineBox? I think InlineBox is quite a good term.

[...]

Btw, is there any CVS repository from which a khtml developer can pull the 
latest WebCore sources?

mfg
	Leo