[Kget] [PATCH] Applets launch KGet on URL drop

Lukas Appelhans l.appelhans at gmx.de
Sun Apr 5 16:32:52 CEST 2009


On Sonntag 05 April 2009 08:32:25 nsm.nikhil at gmail.com wrote:
> Hi,
>
> Currently KGetApplet accepts drops, but only launches via D-BUS, which
> fails if KGet isn't running. Although the error widget has a button to
> launch KGet, it would be better if KGet automatically started on receiving
> a drop. This patch does that by invoking kget via QProcess if D-BUS fails.
>
> The patch should be applied in this directory
>
>    kdenetwork/kget/plasma/applet/common
>
> This is my first patch, so please let me know if I did any mistakes in
> formatting or quality or something.
>
> Thanks.
> Nikhil
Hey!

Thanks for your patch! Although there is one thing not correct...
"QProcess::startDetached("kget", urls);": We should use KGet's dbus-interface 
to add new downloads!

<method name="addTransfer">
      <arg type="s" direction="in"/>
      <arg type="s" direction="in"/>
      <arg type="b" direction="in"/>
    </method>

This would be the correct way for adding new downloads...

Thanks!

Lukas


More information about the Kget mailing list