[Kget] LinkImporter to import from clipboard

Javier Goday jgoday at gmail.com
Tue Oct 21 10:03:10 CEST 2008


Hi,
i totally agree with it too,
only one thing besides spaces instead of tabs

maybe we can create a private method in the link importer to add a new link
to the transfers list

something like addLink(const QString &link) or addTransfer(const QString
&link)
and always do this :
        if (!link.contains("://"))
                link = QString("http://") + link;

        QUrl auxUrl(link);
            if(!link.isEmpty() && auxUrl.isValid() &&
m_transfers.indexOf(link) < 0 &&
                                  !auxUrl.scheme().isEmpty() &&
!auxUrl.host().isEmpty()) {
                m_transfers << link;
            }

just to avoid duplicate code (both slotReadFile and checkClipboard methods
could use it).

Please commit it (or should we commit it ? have you got a svn account
already ?)

bye

On Sun, Oct 19, 2008 at 12:07 PM, Urs Wolfer <uwolfer at kde.org> wrote:

> On Friday 17 October 2008 00:17:49 you wrote:
> > Hello Urs,
> > patch file attached.
>
> Thanks for the patch. It looks fo me basically okay, but I think Javier
> should
> comment on it. He does the work on our importer.
>
> Btw, try to use always spaces instead of tabs.
>
> Bye
> urs
>
> _______________________________________________
> Kget mailing list
> Kget at kde.org
> https://mail.kde.org/mailman/listinfo/kget
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kget/attachments/20081021/844e61ad/attachment.htm 


More information about the Kget mailing list