[dolphin] [Bug 468548] Toggling selection mode with spacebar, on, off, then on again, crashes dolphin

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=468548

Felix Ernst <felixernst at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |23.08
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/commit/49ea43e24
                   |                            |fede0dd001c594db9f35935face
                   |                            |bba8
         Resolution|---                         |FIXED

--- Comment #11 from Felix Ernst <felixernst at kde.org> ---
Git commit 49ea43e24fede0dd001c594db9f35935facebba8 by Felix Ernst, on behalf
of Felix Ernst.
Committed on 20/04/2023 at 14:42.
Pushed by felixernst into branch 'master'.

Reuse existing proxy style

Before this commit, a new QProxyStyle was created every time the
selection mode was enabled. The previously used one was
automatically deleted in the process because of the std::unique_ptr
re-assignment. This isn't really a problem in itself, but I
strongly assume that the sudden deletion of the old style shortly
before setting a new style might be the cause of the crash/bug
468548.

This commit simply re-uses the previously created proxy style which
doesn't seem to cause any behaviour change even when the
application style has been changed in the time since the proxy
style was created.

Another potential solution might be to simply use deleteLater() on
the old proxy style instead of letting std::unique_ptr delete the
old proxy style instantly while it is still in use. That seems more
involved than simply re-using the old style though.
FIXED-IN: 23.08

M  +3    -1    src/views/dolphinview.cpp

https://invent.kde.org/system/dolphin/commit/49ea43e24fede0dd001c594db9f35935facebba8

-- 
You are receiving this mail because:
You are the assignee for the bug.