D29489: [svn] Added SVN Checkout dialog.

[Méven Car]

meven accepted this revision as: meven.
meven added a comment.
This revision is now accepted and ready to land.


  All in all this is good.
  
  I hope you'll do a git dialog ;)
  Unless I do first.

INLINE COMMENTS

> svncheckoutdialog.cpp:50
> +{
> +    if (path.startsWith("file://") || path.startsWith("http://") || path.startsWith("https://") || path.startsWith("svn://") || path.startsWith("svn+ssh://")) {
> +        if (QUrl(path, QUrl::StrictMode).isValid()) {

I would have reversed this, first QUrl::fromUserInput, then isvalid() then .scheme() in [listof svn repo url scheme], but this is fine

> nikolaik wrote in svncheckoutdialog.cpp:73
> Yes, that is correct, this is the most common use strategy.
> The idea was "if clipboard contains correct URL set it through on_leRepository_textChanged() which sets work directory path, if no URL just set the work directory path to the current dir".
> Do you think about something better?

I missed textChanged edited leCheckoutDir.
Your idea is nice.

REPOSITORY
  R449 Plugins for Dolphin

BRANCH
  svn_checkout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29489

To: nikolaik, #vdg, #dolphin, meven, elvisangelaccio, ngraham
Cc: anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200507/907f2cc1/attachment.htm>