D29378: Keep name readable on drag to matching background

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  LGTM besides the inline comment.

INLINE COMMENTS

> kitemlistwidget.cpp:385-386
>  
> +    setSelected(false);
> +
>      setAlternateBackground(oldAlternateBackground);

This shouldn't be needed, since we have already painted the drag pixmap and we are going to call again `setSelected()` at line 388.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29378

To: cchristiansen, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200503/ac1056af/attachment.htm>