D29378: Keep name readable on drag to matching background

Christian Christiansen noreply at phabricator.kde.org
Sun May 3 09:26:27 BST 2020


cchristiansen created this revision.
cchristiansen added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
cchristiansen requested review of this revision.

REVISION SUMMARY
  Previously, when a single item was selected and dragged, the
  name would become unreadable when the text colour matched the
  background colour it was dragged onto.
  
  This is now fixed by not deselecting the item (and hence keeping
  the highlighting around the text) before creating the pixmap for
  dragging.
  
  BUG: 405266

TEST PLAN
  Tested with Breeze and Breeze Dark.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29378

AFFECTED FILES
  src/kitemviews/kitemlistwidget.cpp

To: cchristiansen, #dolphin
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200503/32ceacb7/attachment.htm>


More information about the kfm-devel mailing list