D29321: Port and enable the User Agent Changer plugin

David Faure noreply at phabricator.kde.org
Fri May 1 16:10:18 BST 2020


dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> uachangerplugin.cpp:385
> +
> +    const QUrl u(QString("http://%1/").arg(hostname));
> +    const QString tld = u.topLevelDomain(QUrl::EncodeUnicode);

`QUrl u; u.setScheme("http"); u.setHostName(hostname);` would be better in case of special characters in the hostname.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D29321

To: marten, #konqueror, #plasma, dfaure
Cc: pino, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200501/ef2d3902/attachment.htm>


More information about the kfm-devel mailing list