D29321: Port and enable the User Agent Changer plugin

[Jonathan Marten]

marten added inline comments.

INLINE COMMENTS

> pino wrote in uachangerplugin.cpp:96-104
> please use KLocalizedString::languages() instead

Didn't know about KLocalizedString::languages(), thanks for the pointer.

> dfaure wrote in uachangerplugin.cpp:98
> Are you sure the KConfigGroup keeps the KSharedConfig alive? It would be good if it did, but I'm not sure it does.
> Putting the KSharedConfig into a local var seems safer to me.
> 
> Any reason not to use QLocale().uiLanguages()?

Have used the KSharedConfig::openConfig()->group(...) construct before and it seems to work, but no longer necessary because of below.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D29321

To: marten, #konqueror, #plasma, dfaure
Cc: pino, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200501/5fde94d3/attachment.htm>