D28290: Sync terminal with KIOFuse mount when browing remote directories

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.

INLINE COMMENTS

> terminalpanel.cpp:252
> +        // If we can't do that for any reason, silently fail.
> +        org::kde::KIOFuse::VFS kiofuse_iface(QStringLiteral("org.kde.KIOFuse"),
> +                                             QStringLiteral("/org/kde/KIOFuse"),

Please use camelCase

> fvogt wrote in terminalpanel.cpp:281
> IMO this should first check that it's inside a fuse mount before making an expensive DBus call.
> 
> This could be done using `statvfs` and checking for `f_fsid == 0x65735546 // FUSE_SUPER_MAGIC` or use `KMountPoint` which might be more expensive.

Please use `KMountPoint` or Solid or whatever is the framework for this stuff, because `terminalpanel.cpp` is also built on Windows.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28290

To: feverfew, #dolphin, fvogt, elvisangelaccio
Cc: elvisangelaccio, fvogt, kfm-devel, ngraham, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200329/6dda12ed/attachment.htm>