D28290: Sync terminal with KIOFuse mount when browing remote directories

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> terminalpanel.cpp:281
>  
> +    // User may potentially be browsing inside a KIOFuse mount.
> +    // Lets try and change to the DolphinView to point to the remote URL equivalent.

IMO this should first check that it's inside a fuse mount before making an expensive DBus call.

This could be done using `statvfs` and checking for `f_fsid == 0x65735546 // FUSE_SUPER_MAGIC` or use `KMountPoint` which might be more expensive.

> terminalpanel.cpp:287
> +                                         QDBusConnection::sessionBus());
> +    auto reply = kiofuse_iface.remoteUrl(url.toString());
> +    QDBusPendingCallWatcher * watcher = new QDBusPendingCallWatcher(reply, this);

Has to be `kiofuse_iface.remoteUrl(m_konsolePartCurrentDirectory);`  now

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28290

To: feverfew, #dolphin, fvogt
Cc: fvogt, kfm-devel, ngraham, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200328/3ff248ac/attachment.htm>