D27523: [Moved to invent.kde.org]Add an option to use a KUrlNavigator on the toolbar instead

[Felix Ernst]

felixernst abandoned this revision.
felixernst marked 6 inline comments as done.
felixernst added a comment.


  -> Moved to: https://invent.kde.org/system/dolphin/-/merge_requests/21
  
  As expected the clean way to implement this required a lot of refactoring.
  
  I think I addressed every single comment on this page. If I forgot anything, please remind me on invent.
  I didn't address the "empty trash" button. If we really want a trash button to appear in the toolbar as well I would think it would be better to do that outside the DolphinUrlNavigatorWidgetAction class and therefore probably in a separate merge request just for the button but we can discuss this further if necessary.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D27523

To: felixernst, #vdg, #dolphin
Cc: The-Feren-OS-Dev, cfeck, ngraham, manueljlin, anthonyfieroni, meven, elvisangelaccio, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200614/6168de86/attachment.htm>