D23168: Use embedded cover in MP4 video files

[Heiko Schaefer]

hschaefer added a comment.


  In D23168#675986 <https://phabricator.kde.org/D23168#675986>, @meven wrote:>
  
  > You need to fork the repository in gitlab, before opening the merge request.
  >  Refer to our own instructions https://community.kde.org/Infrastructure/GitLab#Fork_the_project
  >  We also have a tool https://invent.kde.org/sdk/git-lab to simplify the merge request creation/process (it is similar to `arc` but way easier to install, to use and to contribute to).
  
  
  Did a merge request.
  https://invent.kde.org/multimedia/ffmpegthumbs/-/merge_requests/2
  
  In D23168#675986 <https://phabricator.kde.org/D23168#675986>, @meven wrote:>
  
  > IMHO Gitlab is improving things, but since things are transitioning, this adds some friction we are seeing here.
  >  Contributing is not a simple thing : with reviewer time varying and limited and contributors experience varying, this adds some friction. The first patch is usually the hardest.
  >  As long as you don't have to complicate things, things are mostly smooth : here you need to rebase a patch that you opened from the web ui which phabricator does not help with.
  >  For instance git-lab offers in Web Ui a rebase button.
  >
  > Hold on a little more ;)
  
  
  I'm willing to follow all requirements, but if it gets a technical chaos and not a chaos in my contribution, I get annoyed.
  I hope the merge request is okay so far. It is **ONE** commit.

REVISION DETAIL
  https://phabricator.kde.org/D23168

To: hschaefer, bruns, #dolphin, elvisangelaccio, broulik, ngraham, meven
Cc: ngraham, meven, cfeck, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200719/7b8ece41/attachment.htm>