D26921: Add changes list for SVN commit dialog

[Méven Car]

meven accepted this revision as: meven.
meven added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> nikolaik wrote in fileviewsvnplugin.cpp:382
> We should be really careful with this asserts because there is no place documenting for example "There should be no NormalVersion". One can change beginRetrieval() and because we doesn't have test units for everything this could damage SVN plugin in some rare cases.
> In my opinion better to continue working without plugin crash with empty status and qWarning() instead. It is also worth noting that commitFiles() can do its job anyway.

I am fine with either solution.

REVISION DETAIL
  https://phabricator.kde.org/D26921

To: nikolaik, #dolphin, elvisangelaccio, meven, #vdg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200127/ed1def74/attachment.htm>