D23505: added sorting benchmark
Méven Car
noreply at phabricator.kde.org
Sun Jan 19 21:54:31 GMT 2020
meven added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in CMakeLists.txt:42
> Why? We already run another benchmark (kfileitemmodelbenchmark) unconditionally.
Morst benchmarks have no assertions.
If a human does not pay attention to the results, running (or buliding them)is pointless, wasting testing and build time.
We should distinguish those kind of test from the rest unless they have assertions of some sort to detect regression in which case their run time should be be reasonable.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D23505
To: fabiank, #dolphin, elvisangelaccio
Cc: meven, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200119/5ae95bae/attachment.htm>
More information about the kfm-devel
mailing list