D27523: Add an option to use a KUrlNavigator on the toolbar instead

[Felix Ernst]

felixernst added a comment.


  I strongly disagree with the space conern. In many configurations putting the UrlNavigator into the toolbar actually increases the space available for the path. As an example in the following screenshots the information panel is open and the UrlNavigator in the toolbar therefore only has ~14 px (< 3%) less space.
  F8136514: dolphin474px.png <https://phabricator.kde.org/F8136514>
  F8136516: dolphin460px.png <https://phabricator.kde.org/F8136516>
  Keep in mind that when split view mode is enabled the two UrlNavigators currently only get half of this space. Also keep in mind that the space in the toolbar can be greatly increased by removing unwanted buttons from there.
  Furthermore this change mainly increases the available space of the view area.
  
  In D27523#619270 <https://phabricator.kde.org/D27523#619270>, @ngraham wrote:
  
  > we make it configurable after all, but don't add a toggle in the menubar.
  
  
  I don't see a reason to make this feature less discoverable. There are clearly a lot of ppl who want it just looking at T11663 <https://phabricator.kde.org/T11663> and T12308 <https://phabricator.kde.org/T12308>. To me it seems like a clear majority wants this and the feature is very easy to understand.
  
  > And without the visual changes proposed in T11662 <https://phabricator.kde.org/T11662>, the URL navigator's breadcrumbs mode looks visually muddy, and there's a large amount of space in the toolbar that looks draggable but actually isn't because it belongs to the URL Navigator.
  
  I always saw this patch as part of the effort of the UI redesign so I would understand if this couldn't become default behaviour until T11662 <https://phabricator.kde.org/T11662> is implemented. I am still certain though that putting the UrlNavigator into the Toolbar even by default is the right decision.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D27523

To: felixernst, #vdg, #dolphin
Cc: cfeck, ngraham, manueljlin, anthonyfieroni, meven, elvisangelaccio, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200228/a2b12769/attachment.htm>