D27523: Add an option to use a KUrlNavigator on the toolbar instead

[Nathaniel Graham]

ngraham added a comment.


  In terms of the user interaction, I'm impressed. I really like the appearance and also the interaction. IMO it's fine for split view too but I'll admit I'm not a heavy user of split view so it would be nice to get opinions from others.
  
  One thing I'm not so sure about is making it optional. If one objection was code maintainability, doing it one way without adding a provision for configurability would surely involve less code, less logic, and less potential for bugs. I'm also not really sure who the target user for returning it to the old state would be? People who don't like change? Heavy users of split views who don't like the extra click required to access the path of an inactive split view? It's kind of a slippery slope; we can't make every change optional.
  
  This isn't a formal objection to making it optional, just a concern. Anyway, very nice work!

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D27523

To: felixernst, #vdg, #dolphin
Cc: ngraham, manueljlin, anthonyfieroni, meven, elvisangelaccio, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200225/7c07aecf/attachment.htm>