D27790: update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl()

Elvis Angelaccio noreply at phabricator.kde.org
Tue Dec 29 22:29:43 GMT 2020


elvisangelaccio added inline comments.

INLINE COMMENTS

> pdabrowski wrote in dolphinpart.cpp:322
> No, it doesn't work for remote addresses (tested: `fish://localhost/`).
> It shows remote directory contents, but also an error.
> It's because KParts::ReadOnlyPart::openUrl() has its own routine for opening remote urls, which shouldn't be called here:
> 
>   } else {
>       d->openRemoteFile();
>       return true;
>   }

Thanks for the test. I merged the invent patch, can you abandon this one?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D27790

To: pdabrowski, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, badbunny, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kfm-devel/attachments/20201229/06dd475f/attachment.htm>


More information about the kfm-devel mailing list