D27790: update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl()

[Piotr Dabrowski]

pdabrowski added inline comments.

INLINE COMMENTS

> pdabrowski wrote in dolphinpart.cpp:322
> Yes, `KParts::ReadOnlyPart::openUrl()` seems to work fine here.
> I'm not sure if there were any corner cases, but I tested this now with Konqueror, and it works.
> Added merge request: https://invent.kde.org/system/dolphin/-/merge_requests/151/

No, it doesn't work for remote addresses (tested: `fish://localhost/`).
It shows remote directory contents, but also an error.
It's because KParts::ReadOnlyPart::openUrl() has its own routine for opening remote urls, which shouldn't be called here:

  } else {
      d->openRemoteFile();
      return true;
  }

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D27790

To: pdabrowski, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, badbunny, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kfm-devel/attachments/20201229/b691dae1/attachment.htm>