D26215: Port QRegExp to QRegularExpression

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D26215#653371 <https://phabricator.kde.org/D26215#653371>, @ahmadsamir wrote:
  
  > In D26215#652998 <https://phabricator.kde.org/D26215#652998>, @elvisangelaccio wrote:
  >
  > > > KFileItemModelFilter still uses QRegExp as there's no equivalent in QRegularExpression
  > > >  to QRegExp::WildcardUnix.
  > >
  > > Is there any plan to fix this upstream in Qt?
  >
  >
  > I have no idea. According to QRegExp docs:
  >
  > > In the mode Wildcard, the wildcard characters cannot be escaped. In the mode WildcardUnix, the character '\' escapes the wildcard.
  >
  > (I am all for using a full regex, it's more predictable).
  
  
  What about `QRegularExpression::wildcardToRegularExpression()` ? Could we use that? Note that the filter string comes from user input (i.e. from the filter bar).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D26215

To: ahmadsamir, #dolphin, elvisangelaccio, meven
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200426/30be17dd/attachment.htm>