D29089: Dolphin Service Menu Installer: Launch certain scripts in Konsole

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Dolphin, ngraham, nicolasfella, elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
alex requested review of this revision.

REVISION SUMMARY
  In general the issue with installers/uninstallers for the dolphin plugin is
  that a lot of the scripts are intended to be run manually in a terminal.
  For instance if a script uses `sudo make install` the user can't type in the password.
  
  With this patch scripts that are executed without arg variants are 
  executed in konsole (if available).
  
  PS: May this also go into release 20.04.1?

TEST PLAN
  Tests still pass. Try to install the "Jetbrains Dolphin Plugin" tar.gz file from the kde store.

REPOSITORY
  R318 Dolphin

BRANCH
  run_scripts_in_konsole

REVISION DETAIL
  https://phabricator.kde.org/D29089

AFFECTED FILES
  src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp

To: alex, #dolphin, ngraham, nicolasfella, elvisangelaccio
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200422/0c1e3a97/attachment.htm>