D28909: smb: port to Result system to force serialization of error/finish condition

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kio_smb_browse.cpp:184
>              } else {
> -                error(passwordError, url.toString());
>              }

Empty else clause leftover

> kio_smb_file.cpp:169
>          if (errNum == EACCES)
> -            error(KIO::ERR_ACCESS_DENIED, m_openUrl.toDisplayString());
> -        else
> -            error(KIO::ERR_DOES_NOT_EXIST, m_openUrl.toDisplayString());
> -        return;
> +            return Result::fail(KIO::ERR_ACCESS_DENIED, m_openUrl.toDisplayString());
> +        return Result::fail(KIO::ERR_DOES_NOT_EXIST, m_openUrl.toDisplayString());

add {}

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28909

To: sitter, dfaure
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200419/2fd2aecf/attachment.htm>